Skip to content

Commit

Permalink
Update nodejs.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
@paulmillr
paulmillr committed Oct 17, 2019
1 parent 8085759 commit 8344ded
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [8.10.0, 10, 12]
node-version: [8, 10, 12]

This comment has been minimized.

Sign in to view

Copy link
@XhmikosR

XhmikosR Oct 17, 2019

Contributor

Note that currently on Windows 8.10 is used due to actions/setup-node#27.

I also wanted to be clear that this is required, but it's good either way since the engines property states the minimum version.

This comment has been minimized.

Sign in to view

Copy link
@paulmillr

paulmillr Oct 17, 2019

Author Owner

8.16 is required for fsevents on mac

This comment has been minimized.

Sign in to view

Copy link
@XhmikosR

XhmikosR Oct 18, 2019

Contributor

Argg, then we should have use 8.16 in package.json engines like you had in 3.2.1

This comment has been minimized.

Sign in to view

Copy link
@paulmillr

paulmillr Oct 18, 2019

Author Owner

#892
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
Expand Down

0 comments on commit 8344ded

Please sign in to comment.