handle promise rejection when a symlink's target does not exist. Fixe…

[nicks]

…s #955

[jaens]

Is there a reason why this was not merged?

At least it fixes #955 while also not adding more test failures (some of the tests fail on the current main branch anyway, on my machine).

[paulmillr]

reason is simple: it's hard to understand which use cases this will break. We have millions of users, and the tests aren't really comprehensive, since they fail on CIs.

I know that this is not a reason to halt progress, but we need more reviews of each PR etc.

[jaens]

reason is simple: it's hard to understand which use cases this will break.

Uhh, actually, in this case, I don't see how it can break anything, since if the exception is ever triggered, it currently just kills the entire Node.js process?

[nicks]

thanks @paulmillr !

Yeah, I totally appreciate that as the usage of a library approaches large numbers, the chance that any changes will break somebody approaches 1 😅