Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow watch for recursive not existing folder #897

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

exx8
Copy link

@exx8 exx8 commented Oct 9, 2019

Solves #872

This pull request allows user to watch specific not existing folders.
Was achieved via introducing a new function _mostSpecifiedExistingAncestor
We should consider making the function public, as users might be interested in this functionality.

@paulmillr
Copy link
Owner

We need tests for that feature. Also, ensure you conform to chokidar code style e.g. { locations.

@exx8
Copy link
Author

exx8 commented Oct 10, 2019

I added tests.

index.js Outdated Show resolved Hide resolved
@exx8 exx8 requested a review from paulmillr October 14, 2019 16:14
@exx8
Copy link
Author

exx8 commented Oct 14, 2019

I've made the changes that you asked.

@exx8
Copy link
Author

exx8 commented Oct 20, 2019

Ping?

@paulmillr
Copy link
Owner

If i’m reading this correctly, we’ll have a huge performance degradation because of the new IO call for every file. Need to investigate this thoroughly and so some benchmarks.

@exx8
Copy link
Author

exx8 commented Oct 24, 2019

If i’m reading this correctly, we’ll have a huge performance degradation because of the new IO call for every file. Need to investigate this thoroughly and so some benchmarks.

maybe we should use a flag to enable or disable this functionality?

@XhmikosR
Copy link
Contributor

This needs a rebase. Also the curly brackets shouldn't be placed on new lines, there's an extra space in a test message and extra newlines.

@paulmillr paulmillr force-pushed the master branch 2 times, most recently from 368cb02 to 7c50e25 Compare February 6, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants