New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow watch for recursive not existing folder #897
base: master
Are you sure you want to change the base?
Conversation
We need tests for that feature. Also, ensure you conform to chokidar code style e.g. |
I added tests. |
I've made the changes that you asked. |
Ping? |
If i’m reading this correctly, we’ll have a huge performance degradation because of the new IO call for every file. Need to investigate this thoroughly and so some benchmarks. |
maybe we should use a flag to enable or disable this functionality? |
This needs a rebase. Also the curly brackets shouldn't be placed on new lines, there's an extra space in a test message and extra newlines. |
368cb02
to
7c50e25
Compare
Solves #872
This pull request allows user to watch specific not existing folders.
Was achieved via introducing a new function _mostSpecifiedExistingAncestor
We should consider making the function public, as users might be interested in this functionality.