Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if running on Electron (#99) #102

Closed
wants to merge 1 commit into from

Conversation

ashthespy
Copy link

This works on my current Atom (1.39 running on Electron 3.1.10)
FWIW,not sure how useful this is, as Atom stable will be Electron 4.x soon atom/atom#19373 but then again, not sure what VS Code's electron upgrade timeline is..

@paulmillr
Copy link
Owner

I think #101 fixes this — could you try current master?

@ashthespy
Copy link
Author

@paulmillr Works for me!

@ashthespy ashthespy closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants