17.0.2 memory patch #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2021
|
Hi, you wrote a comment that these changes are a HACK, what do you think we need to do to fix this memory leak by a good way that gonna be merged to facebook/react repo ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from discord#1 applied to https://github.com/facebook/react/tree/17.0.2. Equivalent changes are included in React 18 so these patches will not be needed.
discord@b0194a0 has been merged upstream in facebook#16115
react-dompackage has been built on branch https://github.com/paulshen/react/tree/17.0.2-memory-patch-buildUsage instructions
Update
package.jsonwith following{ "react": "17.0.2", "react-dom": "paulshen/react#731ea24f22e78be9efd712594a52f310158d2e8b" }