Adjust tests for 6da99130 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCB-K
commented
Jun 14, 2021
| if(!realPackageName){ | ||
| throw new Error(`cant find real package name for import ${name}`); | ||
| } | ||
|
|
There was a problem hiding this comment.
instead of defaulting to an empty package name (which is what line 133 effectively did), throw an error when the package name is not found. This will make it easier to find bugs like this in the future.
github-actions
bot
force-pushed
the
master
branch
from
2a70f73
to
c00df6f
Compare
…te package.json lacks a name Fixes import-js#2120.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 . I noticed that the tests on this PR import-js#2121 were passing with and without the bug fix, so I adjusted them so that they pick up the regression correctly.
The particular bug only shows up when:
The test previously was checking for a package that was listed in package.json, so that meant it passed regardless of the bug being fixed or not.
I also made a small adjustment to the code, I'll comment it below.