Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen/repeated-pack): Apply Packed Repeated Fields on encodeBinary #187

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(codegen/repeated-pack): Apply Packed Repeated Fields on encodeBinary #187

wants to merge 1 commit into from

Conversation

hyp3rflow
Copy link
Member

@hyp3rflow hyp3rflow commented Mar 14, 2022 •
edited

goals

  • pack repeated fields for scalar numeric types (int, float, double, bool)
  • separate and push each fields for non-packed field. (ex. non-numeric types such as string, nested messages, bytes)
    • messages.ts:L760

related docs

https://developers.google.com/protocol-buffers/docs/encoding#packed

resolves #186

@hyp3rflow hyp3rflow self-assigned this Mar 14, 2022
@hyp3rflow hyp3rflow marked this pull request as draft March 14, 2022 10:11
@hyp3rflow hyp3rflow requested a review from disjukr March 15, 2022 05:09
@hyp3rflow hyp3rflow changed the title WIP(fix/repeated-pack): Apply Packed Repeated Fields on encodeBinary fix(codegen/repeated-pack): Apply Packed Repeated Fields on encodeBinary Mar 15, 2022
@hyp3rflow hyp3rflow marked this pull request as ready for review March 15, 2022 05:09
@hyp3rflow hyp3rflow marked this pull request as draft March 15, 2022 06:19
@hyp3rflow
Copy link
Member Author

Further investigation needed w/ @disjukr for thinking about encodeBinary logic
Issue #186 will be fixed in #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disjukr disjukr Awaiting requested review from disjukr

At least 1 approving review is required to merge this pull request.

Assignees

@hyp3rflow hyp3rflow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wireValue.type of repeated enum fields
1 participant
@hyp3rflow