fix: ensure complex object keys are quoted

Fix chaijs#45
pcorpet · Jun 10, 2021 · b4dea33 · b4dea33
1 parent 5db74c7
commit b4dea33
Show file tree

Hide file tree

Showing 3 changed files with 18,201 additions and 49 deletions.
diff --git a/lib/object.js b/lib/object.js
@@ -1,5 +1,15 @@
 import { inspectProperty, inspectList } from './helpers'
 
+function quoteComplexKey(key) {
+  if (typeof key !== 'string' || key.match(/^[a-zA-Z_][a-zA-Z_0-9]*$/)) {
+    return key
+  }
+  return JSON.stringify(key)
+    .replace(/'/g, "\\'")
+    .replace(/\\"/g, '"')
+    .replace(/(^"|"$)/g, "'")
+}
+
 export default function inspectObject(object, options) {
   const properties = Object.getOwnPropertyNames(object)
   const symbols = Object.getOwnPropertySymbols ? Object.getOwnPropertySymbols(object) : []
@@ -8,12 +18,12 @@ export default function inspectObject(object, options) {
   }
   options.truncate -= 4
   const propertyContents = inspectList(
-    properties.map(key => [key, object[key]]),
+    properties.map(key => [quoteComplexKey(key), object[key]]),
     options,
     inspectProperty
   )
   const symbolContents = inspectList(
-    symbols.map(key => [key, object[key]]),
+    symbols.map(key => [quoteComplexKey(key), object[key]]),
     options,
     inspectProperty
   )