Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request add support for reusing PDM scripts in
tox
for both versions 3 and 4.The following have been achieved:
tox
testing on both versions 3 and 4tox
3 and 4 (and add integration tests for those use cases)tox
commands
into reusable PDM scripts and use them intox
README.md
to advertise this featureNote: for
tox
4, given there is not yet any recommandation, guidelines or official API... I chose one possible implementation but I had many implementation working. One was simply added into the_setup_env
method but it was feeling hackish and sementically wrongNote: given
test_integration.py
is already usingtox
to test, I'm wondering if it still makes sense to call tox from CI aspdm run test
should be enough (will run on the Py version and the tox version from CI). I had to update the CI workflow as thetox4
jobs where not really usingtox4
. I added atox --version
to be able to check the version really in useLast note: The coverage change in
pyproject.toml
is using this fix until next pdm version is released including pdm-project/pdm#1112