Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Babel dependency #76

Merged
merged 2 commits into from Mar 6, 2020

Conversation

goto-bus-stop
Copy link
Contributor

Adds missing dependency and ensures that the preset and plugin can be resolved.

Also applying targets: { nodejs: 'current' } to the env config because the code will be run immediately, by the current version of node, and almost none of the transforms are necessary in modern node.js versions.

Ref #75

Thanks!

Copy link

@Luiz-Monad Luiz-Monad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran in the same problem.

@jhnns
Copy link
Member

jhnns commented Mar 6, 2020

Also applying targets: { nodejs: 'current' } to the env config because the code will be run immediately, by the current version of node, and almost none of the transforms are necessary in modern node.js versions.

I thought this is the default behavior if I don't specify anything.

Anyway, thanks! 👍 Apparently I did not review #69 properly 😞

@jhnns jhnns changed the title Fix babel config fix: Add missing Babel dependency Mar 6, 2020
@jhnns jhnns merged commit 72ff48d into peerigon:master Mar 6, 2020
github-actions bot pushed a commit that referenced this pull request Mar 6, 2020
## [5.0.1](v5.0.0...v5.0.1) (2020-03-06)

### Bug Fixes

* Add missing Babel dependency ([#76](#76)) ([72ff48d](72ff48d))
@github-actions
Copy link

github-actions bot commented Mar 6, 2020

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@goto-bus-stop goto-bus-stop deleted the fix-babel-config branch March 7, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants