Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add precompilation step for create-react-app apps #27

Closed
wants to merge 3 commits into from
Closed

add precompilation step for create-react-app apps #27

wants to merge 3 commits into from

Conversation

Shahor
Copy link
Contributor

@Shahor Shahor commented Jan 5, 2018

Linked to issue #26

@djfdev
Copy link

djfdev commented Jan 19, 2018

Would love to see this merge! I haven’t found another lib that does exactly what this does, but I unfortunately can not compile when including this module.

jhnns
jhnns requested changes May 30, 2018
View reviewed changes
Copy link
Member

@jhnns jhnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍

But needs to be updated to the latest master 😁

@jhnns jhnns mentioned this pull request May 30, 2018
Closed
@Shahor
erge branch 'master' of https://github.com/peerigon/parse-domain
fa44216 
* 'master' of https://github.com/peerigon/parse-domain:
  chore(release): 2.1.1
  refactor: Re-add regex comments
  fix: Support url which has no protocol (#28)
  chore: Replace prepublish with prepare
  chore(release): 2.1.0
  feat: Use trie data structure to decrease file size (#33)
@Shahor
Copy link
Contributor Author

Shahor commented May 30, 2018

@jhnns Should be go to go :)

@jhnns
Copy link
Member

jhnns commented Jun 11, 2018

  • Please remove the tld.js since it is not needed anymore
  • Please also remove the package-lock.json since there were no changes of dependencies

Do you know if create-react-app picks up the .babelrc during compilation?

@Shahor Shahor closed this Jun 12, 2018
@Shahor
Copy link
Contributor Author

Shahor commented Jun 12, 2018

Closed in favor of #37

@jhnns jhnns mentioned this pull request Jun 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnns jhnns jhnns requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shahor @djfdev @jhnns