Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit error on connections when receiving "EXPIRE" #1125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Aug 26, 2023

Closes #924

TODO:

TODO:

Edit tasklist title
Beta Give feedback Tasklist TODO:, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Update docs as well ("Be sure to listen on the error event in case the connection fails.")
    Options
  2. Think whether it breaks something (I'm not that deep into how PeerJS works).
    Options
  3. Options

lib/peer.ts Outdated Show resolved Hide resolved
@jonasgloning
Copy link
Member

jonasgloning commented Aug 26, 2023

Hey @WofWca, thanks for working on this!
I pushed some commits, I hope that's ok:

  1. Emit the error only if the target .peer of the connection matches
  2. Some basic tests

I don't think this will break something.

@WofWca
Copy link
Contributor Author

WofWca commented Aug 28, 2023

Alright, looks like it's your MR now XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error expected on DataConnection when not establishing a connection
2 participants