Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require grammar source #286

Merged
merged 4 commits into from
Jun 11, 2022
Merged

Require grammar source #286

merged 4 commits into from
Jun 11, 2022

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Jun 10, 2022

Stacked on top of #282.

This is a proposed work-around for mozilla/source-map#444. Is this adequate?

@hildjj hildjj requested a review from Mingun June 10, 2022 17:32
Copy link
Member

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message can be cryptic if expected type will not be mentioned in it.

Also, it is better to left a comment why this check is needed

lib/compiler/index.js Outdated Show resolved Hide resolved
@hildjj
Copy link
Contributor Author

hildjj commented Jun 11, 2022

I'll merge this on top of #288.

@hildjj hildjj merged commit 7852239 into peggyjs:main Jun 11, 2022
@hildjj hildjj deleted the require-grammar-source branch June 11, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants