Skip to content

Commit

Permalink
chore(tests): Update usage of Tape
Browse files Browse the repository at this point in the history
As of tape-testing/tape#403, tape requires calling
`end()` at the end of top level tests if there are only nested tests. We
use this pattern extensively

Fixes #420
  • Loading branch information
orangejulius committed Feb 12, 2019
1 parent 87cad8c commit a7fd160
Show file tree
Hide file tree
Showing 16 changed files with 22 additions and 3 deletions.
1 change: 1 addition & 0 deletions test/bundleList.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,5 @@ tape('bundlesList tests', (test) => {
process.argv[2] = previousValue;
});
});
test.end();
});
1 change: 1 addition & 0 deletions test/components/conformsTo.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,6 @@ tape('conformsTo', (test) => {
});

});
test.end();

});
3 changes: 3 additions & 0 deletions test/components/extractFieldsTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,7 @@ tape('readStreamComponents', function(test) {
});

});
test.end();

});

Expand Down Expand Up @@ -1314,6 +1315,7 @@ tape('population fallback tests', (test) => {
});

});
test.end();

});

Expand Down Expand Up @@ -1746,5 +1748,6 @@ tape('negative population fallback tests', (test) => {
});

});
test.end();

});
1 change: 1 addition & 0 deletions test/components/isActiveRecordTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,6 @@ tape('isActiveRecord', function(test) {
});

});
test.end();

});
2 changes: 2 additions & 0 deletions test/components/isNotNullIslandRelated.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ tape('isNotNullIslandRelated tests', (test) => {
});

});
test.end();

});

Expand Down Expand Up @@ -120,4 +121,5 @@ tape('recordHasName', (test) => {
t.end();
});
});
test.end();
});
1 change: 1 addition & 0 deletions test/components/loadJSONTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,5 +137,6 @@ tape('loadJSON tests', (test) => {
});

});
test.end();

});
3 changes: 2 additions & 1 deletion test/components/metadataStream.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ tape('metadataStream tests', (test) => {
t.deepEqual(contents, 'some metadata', 'should be equal');
t.end();
});

});

});

});
test.end();

});
1 change: 1 addition & 0 deletions test/components/parseMetaFiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ tape('parseMetaFiles tests', (test) => {
});

});
test.end();

});
1 change: 1 addition & 0 deletions test/components/recordHasIdAndPropertiesTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,6 @@ tape('recordHasIdAndProperties', function(test) {
t.end();
});
});
test.end();

});
3 changes: 1 addition & 2 deletions test/components/recordHasNameTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ tape('recordHasName', function(test) {
});

});


test.end();

});
2 changes: 2 additions & 0 deletions test/components/wofIdToPath.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,6 @@ tape('wofIdToPath', (t) => {
t.deepEqual(wofIdToPath(0), ['0']);
t.end();
});
t.end();

});
1 change: 1 addition & 0 deletions test/hierarchyFinderTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,6 @@ tape('tests for looking up hierarchies', function(test) {
t.end();

});
test.end();

});
1 change: 1 addition & 0 deletions test/importStreamTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,6 @@ tape('importStream', function(test) {
});

});
test.end();

});
1 change: 1 addition & 0 deletions test/peliasDocGeneratorsTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -587,5 +587,6 @@ tape('create', function(test) {
});

});
test.end();

});
1 change: 1 addition & 0 deletions test/readStreamTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,5 +175,6 @@ tape('readStream', (test) => {

});
});
test.end();

});
2 changes: 2 additions & 0 deletions test/schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ tape('tests for looking up hierarchies', function(test) {
t.end();

});
test.end();

});

Expand Down Expand Up @@ -391,5 +392,6 @@ tape('battery of importPlace tests', test => {
t.end();

});
test.end();

});

0 comments on commit a7fd160

Please sign in to comment.