Dark mode support #102
Merged
Dark mode support #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
reviewed
Mar 17, 2019
draganescu
force-pushed
the
update/dark-mode-support
branch
2 times, most recently
from
9a0e7e7
to
128343f
Compare
Merged
draganescu
force-pushed
the
update/dark-mode-support
branch
2 times, most recently
from
86534eb
to
f813c29
Compare
|
Here's what I noticed while using dark mode:
|
|
One more thing: the little notch pointing at the (W) logo is still white. |
noisysocks
reviewed
Mar 18, 2019
| @@ -94,6 +94,28 @@ function createWindow() { | |||
| } | |||
| } ); | |||
|
|
|||
| if ( process.platform === 'darwin' ) { | |||
There was a problem hiding this comment.
We probably want to have the theme-light class apply by default so that non-Mac clients have the light theme.
talldan
reviewed
Mar 18, 2019
src/components/pages/style.scss
Outdated
| } | ||
| .theme-dark & { | ||
| color: $light-gray-200; | ||
| border-bottom: 1px solid $dark-gray-400; |
There was a problem hiding this comment.
This border doesn't seem to be visible
| text-decoration: underline; | ||
| cursor: pointer; | ||
| background: none; | ||
| display: block; | ||
| font-size: inherit; | ||
| margin: 10px 0; | ||
| padding: 0; | ||
| .theme-light & { |
There was a problem hiding this comment.
Might also need hover/focus/visited styles
| } | ||
| .theme-dark & { | ||
| color: $blue-medium-200; | ||
| border-bottom: 1px solid $dark-gray-400; |
There was a problem hiding this comment.
This border doesn't seem to be visible, maybe the colors are around the wrong way.
| @@ -1,5 +1,5 @@ | |||
| @import "../node_modules/@wordpress/components/build-style/style.css"; | |||
|
|
|||
| @import "./_colors.scss"; | |||
There was a problem hiding this comment.
Seems like this could be removed.
draganescu
force-pushed
the
update/dark-mode-support
branch
from
d39a01a
to
a5099cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for #49
The
package.jsonfile has a new directive that instructs Electron to allow dark mode when the app is packaged, so the chrome respects the OS setting.The
election-runner.jsscript has some logic that relays to the rendered the current system setting about dark mode and the changes to it when the user switches in System Settings.