Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Updated] Check Type(app/web) Validity while creating builds #1157

Merged
merged 15 commits into from
Jan 23, 2023
Merged

✨ [Updated] Check Type(app/web) Validity while creating builds #1157

merged 15 commits into from
Jan 23, 2023

Conversation

hiteshsalavi
Copy link
Contributor

Replacing #1153

@hiteshsalavi hiteshsalavi marked this pull request as ready for review December 13, 2022 09:54
@hiteshsalavi hiteshsalavi mentioned this pull request Dec 13, 2022
Closed
itsjwala
itsjwala suggested changes Dec 13, 2022
View reviewed changes
packages/cli-command/test/command.test.js Outdated Show resolved Hide resolved
packages/cli-command/src/command.js Outdated Show resolved Hide resolved
itsjwala
itsjwala approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good please update tests for remaining files.

itsjwala
itsjwala suggested changes Dec 14, 2022
View reviewed changes
packages/client/src/client.js Outdated Show resolved Hide resolved
packages/core/src/percy.js Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Jan 3, 2023
@itsjwala
Copy link
Contributor

@hiteshsalavi please reopen if you work on this later. closing as it's stale.

@itsjwala itsjwala closed this Jan 12, 2023
@itsjwala itsjwala deleted the hitesh/type-validity-check branch January 12, 2023 12:08
@prklm10 prklm10 restored the hitesh/type-validity-check branch January 18, 2023 13:51
@prklm10 prklm10 reopened this Jan 18, 2023
@itsjwala itsjwala added ✨ enhancement New feature or request and removed 🍞 stale Closed due to inactivity labels Jan 18, 2023
itsjwala
itsjwala approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @prklm10 windows tests for cli-exec seems to be breaking.

@itsjwala itsjwala merged commit 47a206c into master Jan 23, 2023
@itsjwala itsjwala deleted the hitesh/type-validity-check branch January 23, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prklm10 prklm10 prklm10 left review comments

@itsjwala itsjwala itsjwala approved these changes

@ninadbstack ninadbstack ninadbstack approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hiteshsalavi @itsjwala @prklm10 @ninadbstack