✨ skip upload when sha is present #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pankaj443
commented
Jan 5, 2023
pankaj443
commented
- update tile config to include sha
- skip uploading step when sha is present for tiles
itsjwala
changed the title
prklm10
approved these changes
Jan 6, 2023
ninadbstack
reviewed
Jan 6, 2023
packages/client/src/client.js
Outdated
Comment on lines
413
to
420
| if (sha) { | ||
| let success = await this.verifyComparisonTile(comparisonId, sha); | ||
| if (!success) { | ||
| this.log.error(`Uploading comparison tile for ${sha} failed`); | ||
| return false; | ||
| } | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Ideally would loop in here than on API. API loop will adversely affect API Apdex score
There was a problem hiding this comment.
looping here would mean multiple API calls, if we loop in API we will have only 1 api call. Also any changes/fixes can be deployed easily there.
Let me know if its blocking
itsjwala
reviewed
Jan 9, 2023
itsjwala
reviewed
Jan 9, 2023
itsjwala
reviewed
Jan 12, 2023
Bumps [ws](https://github.com/websockets/ws) from 8.10.0 to 8.12.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.10.0...8.12.0) --- updated-dependencies: - dependency-name: ws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
itsjwala
reviewed
Jan 12, 2023
itsjwala
approved these changes
Jan 12, 2023
itsjwala
reviewed
Jan 12, 2023
ninadbstack
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.