Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 don't cache cross snapshot root resources #1176

Merged
merged 2 commits into from
Feb 1, 2023
Merged

🐛 don't cache cross snapshot root resources #1176

merged 2 commits into from
Feb 1, 2023

Conversation

itsjwala
Copy link
Contributor

@itsjwala itsjwala commented Jan 30, 2023 •
edited

@itsjwala itsjwala changed the title 🐛 don't cache cross snapshot resources when disableCache is enabled 🐛 don't cache cross snapshot root resources Jan 31, 2023
samarsault
samarsault approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@samarsault samarsault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@itsjwala itsjwala added the 🐛 bug Something isn't working label Feb 1, 2023
@itsjwala itsjwala merged commit 403206f into master Feb 1, 2023
@itsjwala itsjwala deleted the caching_bug branch February 1, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarsault samarsault samarsault approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset discovery failing with "Snapshots must have a resource with 'is-root' true.If more than one is provided"
2 participants
@itsjwala @samarsault