🐛 fix for parent's baseURI used for iframes #1192

itsjwala · 2023-03-01T12:39:28Z

while serializing the DOM for shadow DOM support in ✨ Shadow DOM serialisation support #1165 we introduced a bug where in we were using document.createDocumentFragment function which creates a fragment of the parent's frame.
This will specifically cause issues for DOMs that have iframes and their domain is different since its baseURI would be different from the parent frame.
To fix this, we're passing the iframe's document while serializing and using this object to create the fragment.
Fixes iFrame missing css #1189

packages/dom/src/clone-dom.js

packages/dom/test/serialize-frames.test.js

itsjwala added 3 commits February 27, 2023 23:10

🐛 Iframe base uri fix

22496dd

add tests

cdb61a2

add node version for nodenv

3ef6160

itsjwala marked this pull request as ready for review March 1, 2023 12:39

itsjwala requested a review from samarsault March 1, 2023 12:39

samarsault reviewed Mar 1, 2023

View reviewed changes

packages/dom/src/clone-dom.js Outdated Show resolved Hide resolved

refactor: address comments

228a6c6

itsjwala requested a review from samarsault March 1, 2023 12:56

samarsault reviewed Mar 1, 2023

View reviewed changes

packages/dom/test/serialize-frames.test.js Show resolved Hide resolved

itsjwala requested a review from samarsault March 1, 2023 13:06

samarsault approved these changes Mar 1, 2023

View reviewed changes

itsjwala merged commit 66bc2dc into master Mar 1, 2023

itsjwala deleted the jigar/iframe_base_uri_fix branch March 1, 2023 15:16

itsjwala added the 🐛 bug Something isn't working label Mar 1, 2023

Provide feedback