Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃懛 update error code for retry logic #1193

Merged
merged 2 commits into from
Mar 3, 2023
Merged

馃懛 update error code for retry logic #1193

merged 2 commits into from
Mar 3, 2023

Conversation

pankaj443
Copy link
Contributor

  • we have updated verify endpoint to raise err code 400, we previously were retying on 409 hence need to update it to fix the retry logic.
  • currently, if a tile is not uploaded in 500ms which is the initial wait time we throw an error.

@pankaj443 pankaj443 changed the title update error code update error code for retry logic Mar 1, 2023
@pankaj443
Copy link
Contributor Author

@itsjwala please review

@itsjwala itsjwala added the 馃Ч maintenance General maintenance label Mar 2, 2023
@itsjwala itsjwala changed the title update error code for retry logic 馃懛 update error code for retry logic Mar 2, 2023
itsjwala
itsjwala reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verify with team as well

@itsjwala itsjwala merged commit 6b56353 into master Mar 3, 2023
@itsjwala itsjwala deleted the Fix_error_code branch March 3, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjwala itsjwala itsjwala approved these changes

@ninadbstack ninadbstack ninadbstack approved these changes

Assignees
No one assigned
Labels
馃Ч maintenance General maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pankaj443 @itsjwala @ninadbstack