Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Check review-state in build:wait #1205

Merged
merged 7 commits into from
Mar 14, 2023
Merged

✨ Check review-state in build:wait #1205

merged 7 commits into from
Mar 14, 2023

Conversation

AaronBuxbaum
Copy link
Contributor

@AaronBuxbaum AaronBuxbaum commented Mar 10, 2023 •
edited by itsjwala

  • build:wait when used with --fail-on-changes exits CLI with non-zero code, when the build is approved, ideally we'd want to exit 0
  • This PR adds an additional flag --pass-if-approved which will exit 0 when the build is approved even when diffs are found.
  • This flag only works when --fail-on-changes is passed

@itsjwala
Copy link
Contributor

Thanks for the contribution, we'll review it in some time.

itsjwala
itsjwala suggested changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to you @AaronBuxbaum

packages/cli-build/src/wait.js Show resolved Hide resolved
@itsjwala itsjwala added the ✨ enhancement New feature or request label Mar 10, 2023
itsjwala
itsjwala reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @AaronBuxbaum!

I've left some additional comments, post which we're gtg

packages/cli-build/src/wait.js Show resolved Hide resolved
packages/cli-build/src/wait.js Outdated Show resolved Hide resolved
packages/cli-build/test/wait.test.js Show resolved Hide resolved
@itsjwala itsjwala changed the title Check review-state in build:wait ✨ Check review-state in build:wait Mar 13, 2023
@AaronBuxbaum
Copy link
Contributor Author

AaronBuxbaum commented Mar 13, 2023 •
edited

@itsjwala ready to go!

Not sure how, but I was seeing these tests fail:

stops waiting on process termination
logs an error when there are no snapshots

I updated them to pass, but give them a look and make any updates desired. then we can push this across the finish line. It might just be my local configuration!

@AaronBuxbaum
Copy link
Contributor Author

@itsjwala ready to go!

Not sure how, but I was seeing these tests fail:

stops waiting on process termination
logs an error when there are no snapshots

I updated them to pass, but give them a look and make any updates desired. then we can push this across the finish line. It might just be my local configuration!

based on CI, it looks like it might be my local configuration. Made a commit to remove those changes.

itsjwala
itsjwala approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @AaronBuxbaum 🔥

Merging this PR (windows CI are known to be flaky) , This will be part of 1.21.0 release ETA end of week.

@itsjwala itsjwala merged commit 8690ff0 into percy:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjwala itsjwala itsjwala approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronBuxbaum @itsjwala