Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows flakes fix attempt 1 #1217

Merged
merged 40 commits into from
Apr 18, 2023
Merged

Windows flakes fix attempt 1 #1217

merged 40 commits into from
Apr 18, 2023

Conversation

samarsault
Copy link
Contributor

@samarsault samarsault commented Mar 22, 2023 •
edited

  • Increasing timeout makes cli-exec and client test pass always
  • @percy/core does not flake on win on multiple runs
  • @percy/client does not flake on win on multiple runs
  • @percy/cli-exec fails with jasmine reporter error
  • @percy/dom - #frame-external did not load in time in test/helpers.js flake. Have seen this on linux as well
  • Root cause of flake is percy does not complete processing when assertion called

@samarsault samarsault added the 🧹 maintenance General maintenance label Mar 22, 2023
@samarsault samarsault marked this pull request as ready for review March 23, 2023 07:01
@samarsault
Copy link
Contributor Author

samarsault commented Mar 30, 2023 •
edited by itsjwala

RUN_REGRESSION

@itsjwala itsjwala changed the title [Draft] Windows flakes fix Windows flakes fix attempt 1 Apr 17, 2023
@itsjwala itsjwala merged commit eb20547 into master Apr 18, 2023
32 checks passed
@itsjwala itsjwala deleted the windows-flake branch April 18, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjwala itsjwala itsjwala approved these changes

Assignees
No one assigned
Labels
🧹 maintenance General maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samarsault @itsjwala