Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix Percy upload for Safari & Mobile #1227

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

hiteshsalavi
Copy link
Contributor

@hiteshsalavi hiteshsalavi commented Apr 4, 2023

localhost keyword not supported in Safari. That causes percy upload html resource to be unable to fetch image resource

https://docs.percy.io/docs/browsers-specific-handling#localhost-proxy-support-on-safari

@samarsault samarsault changed the title Fix - percy upload for Safari browser 馃悰 Fix Percy upload for Safari & Mobile Apr 5, 2023
@samarsault samarsault requested a review from itsjwala April 5, 2023 12:49
@itsjwala itsjwala merged commit df29f60 into master Apr 5, 2023
28 of 32 checks passed
@itsjwala itsjwala deleted the PPLT-1993-percy-upload-for-safari branch April 5, 2023 12:59
@itsjwala itsjwala added the 馃悰 bug Something isn't working label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants