Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ increase interval for polling build #1228

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

itsjwala
Copy link
Contributor

@itsjwala itsjwala commented Apr 4, 2023

  • Increase polling interval for build to default to 10s.
  • polling 1s is unnecessary and also causes stress on API, A build usually doesn't finish in 1s granularity. if less than 1s is given we'll clamp it to 1s

@yashdsaraf
Copy link

As per discussions with product

  1. Min allowed interval will be 1000ms (1 sec) and default will be 10000ms (10 secs).
  2. We will not break if supplied interval is less than allowed interval, simply warn and take the max of both.
  3. Need to print a message after each "non-final" update about the ETA to next update.

@itsjwala itsjwala changed the title 💥 increase interval for polling build ✨ increase interval for polling build Apr 4, 2023
@itsjwala itsjwala merged commit 5ad071c into master Apr 6, 2023
29 of 32 checks passed
@itsjwala itsjwala deleted the jigar/increase-build-wait-interval branch April 6, 2023 06:52
@itsjwala itsjwala added the ✨ enhancement New feature or request label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants