Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ support domTransformation in Page.snapshot function #1238

Merged
merged 3 commits into from
Apr 21, 2023
Merged

✨ support domTransformation in Page.snapshot function #1238

merged 3 commits into from
Apr 21, 2023

Conversation

itsjwala
Copy link
Contributor

@itsjwala itsjwala commented Apr 20, 2023 •
edited

  • domTransformation is a feature of @percy/dom package where in we can run arbitrary JS to modify the snapshotted DOM post serialization - ref
  • Page.snapshot is used by cli-snapshot and percy-storybook packages, other SDKs don't borrow Page from the asset discovery browser we inject PercyDOM script in the user's test browser.
  • With this PR cli snapshot and storybook SDK will be able to leverage domTransformation param.

@itsjwala itsjwala mentioned this pull request Apr 20, 2023
Merged
@itsjwala itsjwala changed the title ✨ support domTransformation for snapshot command ✨ support domTransformation in snapshot function Apr 20, 2023
@itsjwala itsjwala changed the title ✨ support domTransformation in snapshot function ✨ support domTransformation in Page.snapshot function Apr 21, 2023
@itsjwala itsjwala marked this pull request as ready for review April 21, 2023 10:35
@itsjwala
Copy link
Contributor Author

RUN_REGRESSION

@itsjwala itsjwala merged commit 83caeb2 into master Apr 21, 2023
31 of 32 checks passed
@itsjwala itsjwala deleted the dom_transformation_arg branch April 21, 2023 12:10
@itsjwala itsjwala added the ✨ enhancement New feature or request label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninadbstack ninadbstack ninadbstack approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsjwala @ninadbstack