Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression branch validation #1244

Merged
merged 6 commits into from
May 9, 2023
Merged

Regression branch validation #1244

merged 6 commits into from
May 9, 2023

Conversation

samarsault
Copy link
Contributor

@samarsault samarsault commented Apr 25, 2023

Branch input as is can be susceptible to injection attacks

@itsjwala itsjwala added the 🧹 maintenance General maintenance label Apr 25, 2023
@rahul-bs
Copy link

rahul-bs commented May 2, 2023

just to confirm, since you are adding fork check to not run regression which means external users will not be able to run the regression tests with comments
and only our team would be able to contribute to the project

@samarsault
Copy link
Contributor Author

With this change no one will be able to trigger the regression tests on a forked PR. We don't want that. Lets limit the people allowed to run the tests to members with write access

@samarsault samarsault merged commit efaf86e into master May 9, 2023
32 checks passed
@samarsault samarsault deleted the regression-input-sanity branch May 9, 2023 13:56
shahidk8 pushed a commit that referenced this pull request Jun 29, 2023
* Regression fix url and status update

* Validate branch name

* use action for validation

* dont allow forks

* remove fork and add permission check
samarsault added a commit that referenced this pull request Jun 29, 2023
* Regression fix url and status update

* Validate branch name

* use action for validation

* dont allow forks

* remove fork and add permission check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 maintenance General maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants