-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression branch validation #1244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjwala
reviewed
Apr 25, 2023
rahul-bs
reviewed
Apr 26, 2023
rahul-bs
reviewed
Apr 28, 2023
rahul-bs
reviewed
Apr 28, 2023
just to confirm, since you are adding fork check to not run regression which means external users will not be able to run the regression tests with comments |
With this change no one will be able to trigger the regression tests on a forked PR. We don't want that. Lets limit the people allowed to run the tests to members with write access |
ninadbstack
reviewed
May 3, 2023
rahul-bs
approved these changes
May 3, 2023
This was referenced May 3, 2023
This was referenced May 3, 2023
itsjwala
approved these changes
May 4, 2023
rahul-bs
approved these changes
May 9, 2023
shahidk8
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Regression fix url and status update * Validate branch name * use action for validation * dont allow forks * remove fork and add permission check
samarsault
added a commit
that referenced
this pull request
Jun 29, 2023
* Regression fix url and status update * Validate branch name * use action for validation * dont allow forks * remove fork and add permission check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch input as is can be susceptible to injection attacks