🐛 Fixed a replace bug that insert match string in replacement value #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninadbstack
changed the title
ninadbstack
changed the title
ninadbstack
force-pushed
the
PER-2109-fix-replace-bug
branch
from
cf36eb8
to
a688169
Compare
samarsault
reviewed
May 19, 2023
samarsault
reviewed
May 19, 2023
| integrity sha512-bWTlaXUy/rq0BBtYShc/jArYfBPjEV95euvZ8JVtO43oQExEN/WquoqpufFjNu4kSpi5cy5kMbNvzztWDfv1Jg== | ||
| version "1.0.30001488" | ||
| resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001488.tgz" | ||
| integrity sha512-NORIQuuL4xGpIy6iCCQGN4iFjlBXtfKWIenlUuyZJumLRIindLb7wXM+GO8erEhb7vXfcnf4BAg2PrSDN5TNLQ== |
There was a problem hiding this comment.
Why are we changing this? Lets not commit this
There was a problem hiding this comment.
Its printing warning in tests + its only dependency of @babel/preset-env which is a dev-dependency of cli [ so safe to upgrade ]
samarsault
changed the title
shahidk8
pushed a commit
that referenced
this pull request
Jun 29, 2023
…1261) * Fixed replace bug that insert match in return val * Updated test to use withExample
samarsault
pushed a commit
that referenced
this pull request
Jun 29, 2023
…1261) * Fixed replace bug that insert match in return val * Updated test to use withExample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a js bug in replace. [ bug for us, its a functionality of replace ]By default js replace function considers everything as regex replace. so as per docs
if we do
reason being
$&inserts the match string in the place => in "dog cats" we have match dog which we want to replace with&$cats=> replace withdogcats=> final outputdogcats cats.The reason it was breaking because we do
and innerHTML of client dom contains $& in many urls [ and so it was getting replaced with ]
So we are using replacer function that does not trigger this inserts