Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Support loading lazy attribute #1265

Merged
merged 4 commits into from
Jun 2, 2023
Merged

✨ Support loading lazy attribute #1265

merged 4 commits into from
Jun 2, 2023

Conversation

ninadbstack
Copy link
Contributor

Context:

  • We currently did not drop loading="lazy" attribute while serialising dom
  • We do not scroll in discovery phase

Issue:

  • We do not capture resources, especially img src where loading="lazy" attr is present and image is out of viewport
  • So when we render it on percy, the full page screenshot shows broken images [ for out of first viewport images ]

Fix:

  • We now drop loading attribute for img and iframe element

@ninadbstack ninadbstack force-pushed the support-loading-lazy-attribute branch from 06e68a6 to e27d45b Compare May 22, 2023 14:26
@ninadbstack ninadbstack force-pushed the support-loading-lazy-attribute branch from be3e067 to 86def86 Compare May 23, 2023 08:58
@ninadbstack ninadbstack force-pushed the support-loading-lazy-attribute branch from 86def86 to 261d51d Compare May 23, 2023 10:00
@ninadbstack ninadbstack added the ✨ enhancement New feature or request label May 23, 2023
@ninadbstack ninadbstack changed the title Support loading lazy attribute ✨ Support loading lazy attribute May 23, 2023
@ninadbstack ninadbstack mentioned this pull request May 23, 2023
Closed
samarsault
samarsault approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@samarsault samarsault left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@itsjwala itsjwala merged commit 77fc43b into master Jun 2, 2023
30 of 32 checks passed
@itsjwala itsjwala deleted the support-loading-lazy-attribute branch June 2, 2023 08:04
@joewhitsitt joewhitsitt mentioned this pull request Jun 6, 2023
Merged
shahidk8 pushed a commit that referenced this pull request Jun 29, 2023
@ninadbstack
✨ Support loading lazy attribute (#1265)
92586c2 
* Drop loading attr to fix resource discovery imgs

* Renamed maybeTranformElement

* Added tests to transform-dom.test.js

* Added shadow dom tests
samarsault pushed a commit that referenced this pull request Jun 29, 2023
@ninadbstack @samarsault
✨ Support loading lazy attribute (#1265)
b6b38b4 
* Drop loading attr to fix resource discovery imgs

* Renamed maybeTranformElement

* Added tests to transform-dom.test.js

* Added shadow dom tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarsault samarsault samarsault approved these changes

@itsjwala itsjwala itsjwala approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ninadbstack @samarsault @itsjwala