Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build info in percy-info #1269

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Add build info in percy-info #1269

merged 3 commits into from
Jun 2, 2023

Conversation

pankaj443
Copy link
Contributor

  • For support of percy app:exec start/stop we need build id and url. adding as part of percy-info since we use sdk-utils in js SDK so we can make use of this and access using percy.build.id & percy.build.url

@pankaj443 pankaj443 mentioned this pull request May 29, 2023
Merged
@itsjwala itsjwala merged commit 1d0255c into master Jun 2, 2023
31 of 32 checks passed
@itsjwala itsjwala deleted the PAPP_269 branch June 2, 2023 08:03
@itsjwala itsjwala added the ✨ enhancement New feature or request label Jun 2, 2023
shahidk8 pushed a commit that referenced this pull request Jun 29, 2023
@pankaj443
Add build info in percy-info (#1269)
4d3c84a 
* add build info in percy

* fix tests

* make coverage 100%
samarsault pushed a commit that referenced this pull request Jun 29, 2023
@pankaj443 @samarsault
Add build info in percy-info (#1269)
e513a60 
* add build info in percy

* fix tests

* make coverage 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjwala itsjwala itsjwala approved these changes

@prklm10 prklm10 prklm10 approved these changes

@ninadbstack ninadbstack ninadbstack approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pankaj443 @itsjwala @prklm10 @ninadbstack