Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce new config option for cli-snapshot for enabling JS in asset discovery page #1275

Merged
merged 5 commits into from
Jun 6, 2023
Merged

✨ Introduce new config option for cli-snapshot for enabling JS in asset discovery page #1275

merged 5 commits into from
Jun 6, 2023

Conversation

itsjwala
Copy link
Contributor

@itsjwala itsjwala commented Jun 6, 2023 •
edited

  • we now introduce a new config alongside the existing enableJavaScript called cliEnableJavaScript
  • purpose for this new cliEnableJavaScript flag is we'll use it to override Asset discovery browser page JS before taking dom Snapshot
    • since we take dom snapshot in CLI for only cli-snapshot ( or percy snapshot command) this doesn't affect percySnapshot ( or percy exec --) flow
  • This change is backwards compatible and doesn't affect existing users.
  • Tests are updated for a better understanding of the expectations.

@itsjwala itsjwala mentioned this pull request Jun 6, 2023
Closed
ninadbstack
ninadbstack approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ninadbstack ninadbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsjwala itsjwala marked this pull request as ready for review June 6, 2023 12:09
@itsjwala itsjwala added the ✨ enhancement New feature or request label Jun 6, 2023
@itsjwala itsjwala merged commit 73392fc into master Jun 6, 2023
32 checks passed
@itsjwala itsjwala deleted the cli_enableJS branch June 6, 2023 12:28
shahidk8 pushed a commit that referenced this pull request Jun 29, 2023
@itsjwala
✨ Introduce new config option for cli-snapshot for enabling JS in ass…
5ecc13d 
…et discovery page (#1275)

* introduce new config option for cli-snapshot for enabling JS in asset discovery page

* add tests for additional config

* add test coverage

* remove scoped testing

* bump coverage
samarsault pushed a commit that referenced this pull request Jun 29, 2023
@itsjwala @samarsault
✨ Introduce new config option for cli-snapshot for enabling JS in ass…
7a0ef92 
…et discovery page (#1275)

* introduce new config option for cli-snapshot for enabling JS in asset discovery page

* add tests for additional config

* add test coverage

* remove scoped testing

* bump coverage
@renovate renovate bot mentioned this pull request Dec 22, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninadbstack ninadbstack ninadbstack approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsjwala @ninadbstack