rewrite localhost domain for serialized assets to render.percy.local #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjwala
suggested changes
Jun 16, 2023
There was a problem hiding this comment.
Nice @shahidk8, back to you
- update title to
rewrite localhost domain for serialized assets to render.percy.local - Add more description to the description -> background, link our public docs 'why is it an issue?', what are we fixing e.t.c
- Add tests and fix lints error.
shahidk8
changed the title
itsjwala
reviewed
Jun 19, 2023
added 2 commits
June 19, 2023 20:28
itsjwala
reviewed
Jun 19, 2023
itsjwala
reviewed
Jun 20, 2023
added 2 commits
June 20, 2023 22:08
itsjwala
reviewed
Jun 21, 2023
itsjwala
reviewed
Jun 21, 2023
itsjwala
reviewed
Jun 21, 2023
itsjwala
reviewed
Jun 21, 2023
itsjwala
reviewed
Jun 21, 2023
added 2 commits
June 21, 2023 15:21
shahidk8
added a commit
that referenced
this pull request
Jun 29, 2023
…1278) * dom transform localhost url * added test cases and resolved lint issues * lint issues * resolved lint issues * PR comment changes * lint issues * changes from review * review changes * lint resolved * review changes * lint resolve --------- Co-authored-by: “Shahid <“shahid.k@browserstack.com”>
samarsault
pushed a commit
that referenced
this pull request
Jun 29, 2023
…1278) * dom transform localhost url * added test cases and resolved lint issues * lint issues * resolved lint issues * PR comment changes * lint issues * changes from review * review changes * lint resolved * review changes * lint resolve --------- Co-authored-by: “Shahid <“shahid.k@browserstack.com”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1246
Difficulty in showing canvas serialized images on safari browser. Fixed by replacing
localhostwithrender.percy.localread more here https://docs.percy.io/docs/browsers-specific-handling#localhost-proxy-support-on-safari