chore: fix percy types exports for newer typescript #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techn1x
commented
Jul 6, 2023
| @@ -24,7 +24,10 @@ | |||
| "types": "./types/index.d.ts", | |||
There was a problem hiding this comment.
the original "types" remains here for backwards compatibility reasons with older TS / configs
|
@Techn1x please make the changes in all the packages so it's uniform. |
|
@itsjwala which package are you referring to specifically? I already applied the change to all packages in this monorepo that have types. I checked again just now in case I missed one. That test that failed seems unrelated? Flaky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1290
I have tested this via my own application, it resolves the error I was seeing detailed in the issue. I'm no expert at this but this makes sense to me.
Please let me know if there are other steps needed to have this released & published