Added condition to check if dom supports adoptedStyleSheets #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanuk-browserstack
changed the title
ninadbstack
reviewed
Jul 12, 2023
ninadbstack
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adoptedStyleSheets is supported in Safari versions from v16.4 and in automate, Safari v16.3 is only available for the latest mac os.
So if anyone uses Safari from automate to run a test for percy, the test fails with the following error:
[percy] JavascriptError: A JavaScript exception occured: undefined is not an object (evaluating 'dom.adoptedStyleSheets')
Now a check is added to verify if adoptedStyleSheets is supported. If not supported, it will show a warning and continue processing.