Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃Ч Fix docs for override -> options #1322

Merged
merged 1 commit into from
Jul 19, 2023
Merged

馃Ч Fix docs for override -> options #1322

merged 1 commit into from
Jul 19, 2023

Conversation

ninadbstack
Copy link
Contributor

@ninadbstack ninadbstack commented Jul 19, 2023 •
edited

As per #819 overrides was renamed to options but README and some comment references were missed. Fixing it in current PR

@ninadbstack ninadbstack requested a review from a team as a code owner July 19, 2023 14:03
@ninadbstack ninadbstack mentioned this pull request Jul 19, 2023
Closed
itsjwala
itsjwala approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, might require updates on docs.percy.io

@ninadbstack ninadbstack merged commit 3a84b95 into master Jul 19, 2023
32 of 34 checks passed
@ninadbstack ninadbstack deleted the fix-docs-for-override-usage branch July 19, 2023 14:23
@ninadbstack ninadbstack added the 馃Ч maintenance General maintenance label Jul 19, 2023
rishigupta1599 pushed a commit that referenced this pull request Aug 7, 2023
@ninadbstack @rishigupta1599
Fix docs for override -> options (#1322)
90d7df0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarsault samarsault samarsault approved these changes

@itsjwala itsjwala itsjwala approved these changes

Assignees
No one assigned
Labels
馃Ч maintenance General maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ninadbstack @samarsault @itsjwala