-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃Ч Added graceful handling of aborted requests #1329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninadbstack
force-pushed
the
handle-aborted-requests-in-discovery
branch
2 times, most recently
from
July 27, 2023 07:44
d16306d
to
0b89f21
Compare
ninadbstack
force-pushed
the
handle-aborted-requests-in-discovery
branch
from
July 27, 2023 07:52
0b89f21
to
59c3324
Compare
samarsault
reviewed
Jul 27, 2023
samarsault
reviewed
Jul 27, 2023
itsjwala
reviewed
Jul 27, 2023
itsjwala
reviewed
Jul 27, 2023
Co-authored-by: Samarjeet <samarsault@gmail.com>
itsjwala
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice!
samarsault
approved these changes
Jul 27, 2023
ninadbstack
changed the title
Added graceful handling of aborted requests
馃Ч Added graceful handling of aborted requests
Jul 27, 2023
rishigupta1599
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Added graceful handling of aborted requests * Update packages/core/src/network.js Co-authored-by: Samarjeet <samarsault@gmail.com> --------- Co-authored-by: Samarjeet <samarsault@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
session.send
call we check if we have already received abortion event for same request idError: Protocol error (Fetch.fulfillRequest): Invalid InterceptionId.
Why?
srcset
with multiple entries and you change the width of the browser fast enough such that it starts loading one of the resources, but now it doesn't need it ]Network.requestWillBeSent
event, which we would eventually respond withFetch.continueRequest
orFetch.fulfillRequest
etc, but before we respond if the request gets cancelled [which invalidatesInterception Id
] we get above Protocol error.Test:
fetchWithTimeout
helper so that we can mimic a cancellation from browserFetch.continueRequest
response by 1 sec so that request triggered byfetch
is cancelledFetch.*
method with a request/interception Id of a request thats already cancelled