Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fixed mimetype check for url [ for fonts ] #1387

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ninadbstack
Copy link
Contributor

Changes:

  • We recently updated CLI to include mimetype check for font files to use makeDirectRequest call even when font files do not return correct Content-Type in the response.
  • But the mimetype package we used does not ignore query params in url, so this fixes url by stripping query params before sending to mimetype check.

Note: We only use detected mimetype for this fetch from makeDirectRequest call. We do not override original mimetype with detected mimetype unless it was originally text/plain [ which is existing behaviour ]

@ninadbstack ninadbstack force-pushed the PER-2551-fix-font-direct-fetch branch from a7759fd to a26437e Compare October 4, 2023 13:30
@ninadbstack ninadbstack merged commit 5d95e76 into master Oct 4, 2023
34 of 36 checks passed
@ninadbstack ninadbstack deleted the PER-2551-fix-font-direct-fetch branch October 4, 2023 13:50
@ninadbstack ninadbstack added the 馃悰 bug Something isn't working label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants