[PER-2574] Icons not loading when noscript tags are present.
#1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanuk-browserstack
changed the title
noscript tags are present.
ninadbstack
approved these changes
Oct 19, 2023
gfellerph
added a commit
to swisspost/design-system
that referenced
this pull request
Nov 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@changesets/parse](https://togithub.com/changesets/changesets/tree/main#readme) ([source](https://togithub.com/changesets/changesets)) | [`0.1.0` -> `0.3.16`](https://renovatebot.com/diffs/npm/@changesets%2fparse/0.1.0/0.3.16) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@percy/cli](https://togithub.com/percy/cli) | [`1.27.3` -> `1.27.4`](https://renovatebot.com/diffs/npm/@percy%2fcli/1.27.3/1.27.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@stencil-community/eslint-plugin](https://togithub.com/stencil-community/stencil-eslint) | [`0.5.0` -> `0.6.0`](https://renovatebot.com/diffs/npm/@stencil-community%2feslint-plugin/0.5.0/0.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`18.17.19` -> `18.18.8`](https://renovatebot.com/diffs/npm/@types%2fnode/18.17.19/18.18.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`18.2.34` -> `18.2.35`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.34/18.2.35) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint](https://eslint.org) ([source](https://togithub.com/eslint/eslint)) | [`8.52.0` -> `8.53.0`](https://renovatebot.com/diffs/npm/eslint/8.52.0/8.53.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [start-server-and-test](https://togithub.com/bahmutov/start-server-and-test) | [`2.0.1` -> `2.0.2`](https://renovatebot.com/diffs/npm/start-server-and-test/2.0.1/2.0.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [zone.js](https://togithub.com/angular/angular) ([changelog](https://togithub.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | [`0.14.1` -> `0.14.2`](https://renovatebot.com/diffs/npm/zone.js/0.14.1/0.14.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>changesets/changesets (@​changesets/parse)</summary> ### [`v0.3.16`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.16) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.15...@changesets/parse@0.3.16) ##### Patch Changes - Updated dependencies \[[`521205d`](https://togithub.com/changesets/changesets/commit/521205dc8c70fe71b181bd3c4bb7c9c6d2e721d2)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​5](https://togithub.com/5).2.1 ### [`v0.3.15`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.15) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.14...@changesets/parse@0.3.15) ##### Patch Changes - Updated dependencies \[[`8c08469`](https://togithub.com/changesets/changesets/commit/8c0846977597ddaf51aaeb35f1f0f9428bf8ba14)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​5](https://togithub.com/5).2.0 ### [`v0.3.14`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.14) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.13...@changesets/parse@0.3.14) ##### Patch Changes - Updated dependencies \[[`dd9b76f`](https://togithub.com/changesets/changesets/commit/dd9b76f162a546ae8b412e0cb10277f971f3585e)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​5](https://togithub.com/5).1.0 ### [`v0.3.13`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.13) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.12...@changesets/parse@0.3.13) ##### Patch Changes - Updated dependencies \[[`c87eba6`](https://togithub.com/changesets/changesets/commit/c87eba6f80a34563b7382f87472c29f6dafb546c)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​5](https://togithub.com/5).0.0 ### [`v0.3.12`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.12) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.11...@changesets/parse@0.3.12) ##### Patch Changes - Updated dependencies \[[`27a5a82`](https://togithub.com/changesets/changesets/commit/27a5a82188914570d192162f9d045dfd082a3c15)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​4](https://togithub.com/4).1.0 ### [`v0.3.11`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.11) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.10...@changesets/parse@0.3.11) ##### Patch Changes - [#​740](https://togithub.com/changesets/changesets/pull/740) [`957e39c`](https://togithub.com/changesets/changesets/commit/957e39c21549dd91e03faa5cd30e44e4c3d7331f) Thanks [@​akphi](https://togithub.com/akphi)! - Fixed an issue with failing to parse changesets containing a completely empty summary. ### [`v0.3.10`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.10) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.9...@changesets/parse@0.3.10) ##### Patch Changes - Updated dependencies \[[`9a993ba`](https://togithub.com/atlassian/changesets/commit/9a993ba09629c1620d749432520470cec49d3a96)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​4](https://togithub.com/4).0.2 ### [`v0.3.9`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.9) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.8...@changesets/parse@0.3.9) ##### Patch Changes - Updated dependencies \[[`e89e28a`](https://togithub.com/atlassian/changesets/commit/e89e28a05f5fa43307db73812a6bcd269b62ddee)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​4](https://togithub.com/4).0.1 ### [`v0.3.8`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.8) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.7...@changesets/parse@0.3.8) ##### Patch Changes - Updated dependencies \[[`de2b4a5`](https://togithub.com/atlassian/changesets/commit/de2b4a5a7b244a37d94625bcb70ecde9dde5b612)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​4](https://togithub.com/4).0.0 ### [`v0.3.7`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.7) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.6...@changesets/parse@0.3.7) ##### Patch Changes - [`5b6005e`](https://togithub.com/atlassian/changesets/commit/5b6005e0349a105b3d138fccdb22d13de8949862) [#​462](https://togithub.com/atlassian/changesets/pull/462) Thanks [@​Andarist](https://togithub.com/Andarist)! - Fixed an issue with failing to parse changesets containing Windows newlines. ### [`v0.3.6`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.6) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.5...@changesets/parse@0.3.6) ##### Patch Changes - Updated dependencies \[[`2b49d66`](https://togithub.com/atlassian/changesets/commit/2b49d668ecaa1333bc5c7c5be4648dda1b11528d)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​3](https://togithub.com/3).0.0 ### [`v0.3.5`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.5) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.4...@changesets/parse@0.3.5) ##### Patch Changes - [`1706fb7`](https://togithub.com/atlassian/changesets/commit/1706fb751ecc2f5a792c42f467b2063078d58716) [#​321](https://togithub.com/atlassian/changesets/pull/321) Thanks [@​mitchellhamilton](https://togithub.com/mitchellhamilton)! - Fix TypeScript declarations - Updated dependencies \[[`1706fb7`](https://togithub.com/atlassian/changesets/commit/1706fb751ecc2f5a792c42f467b2063078d58716)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​2](https://togithub.com/2).0.1 ### [`v0.3.4`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.4) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.3...@changesets/parse@0.3.4) ##### Patch Changes - Updated dependencies \[[`011d57f`](https://togithub.com/atlassian/changesets/commit/011d57f1edf9e37f75a8bef4f918e72166af096e)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​2](https://togithub.com/2).0.0 ### [`v0.3.3`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.3) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.3.2...@changesets/parse@0.3.3) ##### Patch Changes - [`04ddfd7`](https://togithub.com/atlassian/changesets/commit/04ddfd7c3acbfb84ef9c92873fe7f9dea1f5145c) [#​305](https://togithub.com/atlassian/changesets/pull/305) Thanks [@​Noviny](https://togithub.com/Noviny)! - Add link to changelog in readme - Updated dependencies \[[`04ddfd7`](https://togithub.com/atlassian/changesets/commit/04ddfd7c3acbfb84ef9c92873fe7f9dea1f5145c), [`e56928b`](https://togithub.com/atlassian/changesets/commit/e56928bbd6f9096def06ac37487bdbf28efec9d1)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​1](https://togithub.com/1).0.1 ### [`v0.3.2`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/parse%400.3.2) ##### Patch Changes - [`41e2e3d`](https://togithub.com/atlassian/changesets/commit/41e2e3dd1053ff2f35a1a07e60793c9099f26997) [#​292](https://togithub.com/atlassian/changesets/pull/292) Thanks [@​acheronfail](https://togithub.com/acheronfail)! - Fix `repository` field in package.json - Updated dependencies \[[`41e2e3d`](https://togithub.com/atlassian/changesets/commit/41e2e3dd1053ff2f35a1a07e60793c9099f26997), [`cc8c921`](https://togithub.com/atlassian/changesets/commit/cc8c92143d4c4b7cca8b9917dfc830a40b5cda20), [`cc8c921`](https://togithub.com/atlassian/changesets/commit/cc8c92143d4c4b7cca8b9917dfc830a40b5cda20), [`2363366`](https://togithub.com/atlassian/changesets/commit/2363366756d1b15bddf6d803911baccfca03cbdf)]: - [@​changesets/types](https://togithub.com/changesets/types)[@​1](https://togithub.com/1).0.0 ### [`v0.3.0`](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.2.1...@changesets/parse@0.3.0) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.2.1...@changesets/parse@0.3.0) ### [`v0.2.1`](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.2.0...@changesets/parse@0.2.1) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.2.0...@changesets/parse@0.2.1) ### [`v0.2.0`](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.1.2...@changesets/parse@0.2.0) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.1.2...@changesets/parse@0.2.0) ### [`v0.1.2`](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.1.0...@changesets/parse@0.1.2) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/parse@0.1.0...@changesets/parse@0.1.2) </details> <details> <summary>percy/cli (@​percy/cli)</summary> ### [`v1.27.4`](https://togithub.com/percy/cli/releases/tag/v1.27.4) [Compare Source](https://togithub.com/percy/cli/compare/v1.27.3...v1.27.4) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### ✨ Enhancements - Do not execute git commands when `PERCY_SKIP_GIT_CHECK` is set to True by [@​shantanuk-browserstack](https://togithub.com/shantanuk-browserstack) in [percy/cli#1400 - adding endpoint for sending failed event by [@​prklm10](https://togithub.com/prklm10) in [percy/cli#1401 - Introduce new config option enableLayout for enabling layout testing. by [@​prklm10](https://togithub.com/prklm10) in [percy/cli#1378 - Fix percyCSS not getting applied when elements outside `</body>` by [@​itsjwala](https://togithub.com/itsjwala) in [percy/cli#1415 ##### 🐛 Bug Fixes - Icons not loading when `noscript` tags are present. by [@​shantanuk-browserstack](https://togithub.com/shantanuk-browserstack) in [percy/cli#1404 - Percy on Automate - Fixing percyScreenshotEnd response by [@​rishigupta1599](https://togithub.com/rishigupta1599) in [percy/cli#1427 ##### 🏗 Maintenance - Percy on Automate - Removing Redundant Calls for PoA by [@​Amit3200](https://togithub.com/Amit3200) in [percy/cli#1413 **Full Changelog**: percy/cli@v1.27.3...v1.27.4 </details> <details> <summary>stencil-community/stencil-eslint (@​stencil-community/eslint-plugin)</summary> ### [`v0.6.0`](https://togithub.com/stencil-community/stencil-eslint/releases/tag/v0.6.0) [Compare Source](https://togithub.com/stencil-community/stencil-eslint/compare/v0.5.0...v0.6.0) ##### ❗ Breaking Changes - Node v12 and v14 deprecated. ##### What's Changed - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [stencil-community/stencil-eslint#87 - chore(deps): bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [stencil-community/stencil-eslint#93 - chore(deps): bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [stencil-community/stencil-eslint#94 - Ban default true by [@​ysulyma](https://togithub.com/ysulyma) in [stencil-community/stencil-eslint#75 - chore(deps-dev): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.20.12 to 7.23.2 by [@​dependabot](https://togithub.com/dependabot) in [stencil-community/stencil-eslint#98 - 🌟 chore: upgrade Eslint parser to 6.x by [@​philippesic](https://togithub.com/philippesic) in [stencil-community/stencil-eslint#97 🌟 ##### New Contributors - [@​ysulyma](https://togithub.com/ysulyma) made their first contribution in [stencil-community/stencil-eslint#75 - [@​philippesic](https://togithub.com/philippesic) made their first contribution in [stencil-community/stencil-eslint#97 **Full Changelog**: stencil-community/stencil-eslint@v0.5.0...v0.6.0 </details> <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.53.0`](https://togithub.com/eslint/eslint/releases/tag/v8.53.0) [Compare Source](https://togithub.com/eslint/eslint/compare/v8.52.0...v8.53.0) #### Features - [`528e1c0`](https://togithub.com/eslint/eslint/commit/528e1c00dc2aa8636e5b706c4270dc655cfa17e3) feat: Deprecate formatting rules ([#​17696](https://togithub.com/eslint/eslint/issues/17696)) (Nicholas C. Zakas) - [`c0b11dd`](https://togithub.com/eslint/eslint/commit/c0b11ddb9f8aacc64c3933b9f278939aa7bea481) feat: Add suggestions for no-prototype-builtins ([#​17677](https://togithub.com/eslint/eslint/issues/17677)) (Yonathan Randolph) #### Bug Fixes - [`1ad6257`](https://togithub.com/eslint/eslint/commit/1ad6257744d63281235fcc33288394b1d69b34ce) fix: ensure that exit code for fatal errors is not overwritten ([#​17683](https://togithub.com/eslint/eslint/issues/17683)) (Milos Djermanovic) - [`b329ea7`](https://togithub.com/eslint/eslint/commit/b329ea748dff45f11c7e218208244dc24fcb5c8f) fix: add `;` after JSX nodes in `no-object-constructor` autofix ([#​17672](https://togithub.com/eslint/eslint/issues/17672)) (Francesco Trotta) #### Documentation - [`ab8c60d`](https://togithub.com/eslint/eslint/commit/ab8c60d4f859cec787b5a12f7271b40e666235f5) docs: change position of return to top button ([#​17688](https://togithub.com/eslint/eslint/issues/17688)) (Tanuj Kanti) - [`4fc44c0`](https://togithub.com/eslint/eslint/commit/4fc44c0b8c5dca466bffdfe01dfd80794d7762b7) docs: update twitter icon to new X icon ([#​17687](https://togithub.com/eslint/eslint/issues/17687)) (Tanuj Kanti) - [`4164b2c`](https://togithub.com/eslint/eslint/commit/4164b2ceec89726b18ea0b0e34fab05735d55a09) docs: Update README (GitHub Actions Bot) - [`8651895`](https://togithub.com/eslint/eslint/commit/8651895ca7ae15e13d74c8be67d9eebd63a7ce1f) docs: Fix tabs in rule examples ([#​17653](https://togithub.com/eslint/eslint/issues/17653)) (Francesco Trotta) - [`3aec1c5`](https://togithub.com/eslint/eslint/commit/3aec1c55ba2c6d2833e1c0afe0a58f0cc6bbc0a4) docs: explained rule fixers and suggestions ([#​17657](https://togithub.com/eslint/eslint/issues/17657)) (Josh Goldberg ✨) #### Chores - [`ba4d4d5`](https://togithub.com/eslint/eslint/commit/ba4d4d567a82554250dd8c7933322824e6a73944) chore: remove metascraper ([#​17707](https://togithub.com/eslint/eslint/issues/17707)) (Milos Djermanovic) - [`0d07338`](https://togithub.com/eslint/eslint/commit/0d0733882944b4849d71a40723c251213698cef9) chore: Update dependencies ([#​17706](https://togithub.com/eslint/eslint/issues/17706)) (Milos Djermanovic) - [`93256a3`](https://togithub.com/eslint/eslint/commit/93256a32e312f3f4e5c532762df71bdc06bded20) chore: package.json update for [@​eslint/js](https://togithub.com/eslint/js) release (ESLint Jenkins) - [`485ec7d`](https://togithub.com/eslint/eslint/commit/485ec7d08ed2040c292f52bf9b9152f6c8ef4809) test: fix ESLint tests for caching ([#​17699](https://togithub.com/eslint/eslint/issues/17699)) (Milos Djermanovic) - [`db06a7f`](https://togithub.com/eslint/eslint/commit/db06a7ff7992a74368f03d1f21beb00df0407021) ci: bump actions/setup-node from 3 to 4 ([#​17676](https://togithub.com/eslint/eslint/issues/17676)) (dependabot\[bot]) - [`994596b`](https://togithub.com/eslint/eslint/commit/994596b07f5ff20a615a4be1ea03e5fd59cdb84b) ci: run tests in Node.js 21 ([#​17673](https://togithub.com/eslint/eslint/issues/17673)) (Francesco Trotta) </details> <details> <summary>bahmutov/start-server-and-test (start-server-and-test)</summary> ### [`v2.0.2`](https://togithub.com/bahmutov/start-server-and-test/releases/tag/v2.0.2) [Compare Source](https://togithub.com/bahmutov/start-server-and-test/compare/v2.0.1...v2.0.2) ##### Bug Fixes - **deps:** update dependency wait-on to v7.1.0 ([efe7384](https://togithub.com/bahmutov/start-server-and-test/commit/efe7384f4e7befbd30b90a985fd518d86d3f3044)) </details> <details> <summary>angular/angular (zone.js)</summary> ### [`v0.14.2`](https://togithub.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#0142-2023-11-03) [Compare Source](https://togithub.com/angular/angular/compare/zone.js-0.14.1...zone.js-0.14.2) ##### Bug Fixes - **zone.js:** disable wrapping unhandled promise error by default ([6d7eb35](https://togithub.com/angular/angular/commit/6d7eb3548c5fc3aedb4a52ff2010141343748e90)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/swisspost/design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Philipp Gfeller <philipp.gfeller@post.ch>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed that when there are
noscripttags are present in dom and using percy with sdk's, some icons were not getting loaded.Asset discovery itself was not making requests to particular icon file.
This is fixed by excluding the
noscripttags during cloning the dom.