fix: Introduce cross-spawn for cross platform commands #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs a little testing but I believe this will make all of our windows `percy exec -- mvn.cmd test` type deals go away 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR introduces cross platform spawning of commands. Will close #174.
The problem is Windows users need to use the
execcommand like this:If they don't, we can't spawn their original test command. What's happening is nodes
spawnignores windowsPATHEXTwhich is kinda like$PATH& that meansspawnonly works on Windows for.exefiles. See:Tested here: https://github.com/percy/example-percy-cypress/compare/rd/test-cross-platform
The first commit uses
cross_spawnand successfully starts Cypress. The second commit uses0.4.0of agent and fails to start Cypress.