optional parameters for find-by-name in employee-db

perfana · Jun 5, 2021 · cb3f264 · cb3f264
1 parent 05c3690
commit cb3f264
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/afterburner-java/src/main/java/nl/stokpop/afterburner/controller/DatabaseConnector.java b/afterburner-java/src/main/java/nl/stokpop/afterburner/controller/DatabaseConnector.java
@@ -53,8 +53,9 @@ public BurnerMessage checkDatabaseConnection() {
     @ApiOperation(value = "Find employees by name.")
     @GetMapping("/db/employee/find-by-name")
     public List<Employee> findEmployeeByFirstName(
-        @RequestParam(value = "firstName") String firstName,
-        @RequestParam(value = "lastName") String lastName) {
+        @RequestParam(required = false, defaultValue = "") String firstName,
+        @RequestParam(required = false, defaultValue = "") String lastName) {
+
         if (firstName.length() == 0 && lastName.length() > 0) {
             return employeeMapper.selectEmployeeByLastName(lastName);
         }
@@ -71,13 +72,13 @@ else if (firstName.length() > 0) {
 
     @ApiOperation(value = "Find employees by last name.")
     @GetMapping("/db/employee/find-by-last-name")
-    public List<Employee> findEmployeeByLastName(@RequestParam(value = "lastName", defaultValue = "Kolvik") String lastName) {
+    public List<Employee> findEmployeeByLastName(@RequestParam(defaultValue = "") String lastName) {
         return employeeMapper.selectEmployeeByLastName(lastName);
     }
 
     @ApiOperation(value = "Execute long query.")
     @GetMapping("/db/employee/select-long-time")
-    public int longQuery(@RequestParam(value = "durationInSec") int durationInSec) {
+    public int longQuery(@RequestParam int durationInSec) {
         return employeeMapper.selectLongTime(durationInSec);
     }
 }