New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test : write test cases for components #6

Merged

nishantbisen09 merged 4 commits into master from component-test-cases

Feb 6, 2021

Collaborator

nishantbisen09 commented Feb 4, 2021 •

edited

What?

Written test cases for all the Custom Components in the application.
Provided 100% code coverage for these components.
Added enzyme support to test Stateful Components.
Removed React.CreateElement in CopyToClipboard component and added <textarea />

Screenshots

nishantbisen09 added 2 commits

February 4, 2021 17:04


          Test : write test cases for components

3b319d0


          remove obsolete test case

02313ae

nishantbisen09 requested a review from ArfatSalman

February 4, 2021 12:13

nishantbisen09 self-assigned this


          Tests | write test cases for container component(s)

20f45b1

Collaborator Author

nishantbisen09 commented Feb 5, 2021

Update

Added test cases for LyricAppContainer

Screenshots

Overall Coverage

All files coverage

ArfatSalman suggested changes

View reviewed changes

Contributor

ArfatSalman left a comment

Rewrite every test in LyricsAppContainer.test.js and remove Enzyme from your code. Try to use RTL for now.

Let me know if something is not achievable using RTL, then we'll consider Enzyme.

Generally, you'd not mix two different types of testing libraries in the same app.

src/components/resultCard/ResultCard.js Outdated Show resolved Hide resolved

src/tests/components/copyToClipBoard/CopyToClipboard.test.js Outdated Show resolved Hide resolved

src/tests/components/copyToClipBoard/CopyToClipboard.test.js Outdated Show resolved Hide resolved

src/tests/components/lyricDetailViewer/LyricDetailViewer.test.js Outdated Show resolved Hide resolved

src/tests/components/lyricDetailViewer/LyricDetailViewer.test.js Outdated Show resolved Hide resolved

src/tests/pages/LyricsAppContainer.test.js Outdated Show resolved Hide resolved

src/tests/pages/LyricsAppContainer.test.js Outdated Show resolved Hide resolved

src/tests/pages/LyricsAppContainer.test.js Outdated Show resolved Hide resolved

src/tests/pages/LyricsAppContainer.test.js Outdated Show resolved Hide resolved

src/utility/appConstants.js Outdated Show resolved Hide resolved


          Change Request: rewrite test cases for LyricAppContainer

ea217d2

nishantbisen09 merged commit 6b7ed26 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment