Skip to content

Commit

Permalink
.toSpliced should throw a TypeError instead of RangeError
Browse files Browse the repository at this point in the history
  • Loading branch information
petamoriken committed Jun 10, 2022
1 parent 0571b29 commit bf0bf5e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/Float16Array.mjs
Expand Up @@ -17,6 +17,7 @@ import {
CANNOT_MIX_BIGINT_AND_OTHER_TYPES,
DERIVED_CONSTRUCTOR_CREATED_TYPEDARRAY_OBJECT_WHICH_WAS_TOO_SMALL_LENGTH,
ITERATOR_PROPERTY_IS_NOT_CALLABLE,
MAXIMUM_ALLOWED_LENGTH_EXCEEDED,
OFFSET_IS_OUT_OF_BOUNDS,
REDUCE_OF_EMPTY_ARRAY_WITH_NO_INITIAL_VALUE,
SPECIES_CONSTRUCTOR_DIDNT_RETURN_TYPEDARRAY_OBJECT,
Expand All @@ -38,6 +39,7 @@ import {
NativeWeakMap,
NativeWeakSet,
NumberIsNaN,
NumberMAX_SAFE_INTEGER,
ObjectDefineProperty,
ObjectFreeze,
ObjectHasOwn,
Expand Down Expand Up @@ -1067,6 +1069,9 @@ export class Float16Array {

// don't use SpeciesConstructor
const newLength = length + insertCount - actualDeleteCount;
if (newLength > NumberMAX_SAFE_INTEGER) {
throw NativeTypeError(MAXIMUM_ALLOWED_LENGTH_EXCEEDED);
}
const proxy = new Float16Array(newLength);
const array = getFloat16BitsArray(proxy);

Expand Down
1 change: 1 addition & 0 deletions src/_util/messages.mjs
Expand Up @@ -19,4 +19,5 @@ export const CANNOT_MIX_BIGINT_AND_OTHER_TYPES =
export const ITERATOR_PROPERTY_IS_NOT_CALLABLE = "@@iterator property is not callable";
export const REDUCE_OF_EMPTY_ARRAY_WITH_NO_INITIAL_VALUE =
"Reduce of empty array with no initial value";
export const MAXIMUM_ALLOWED_LENGTH_EXCEEDED = "Maximum allowed length exceeded";
export const OFFSET_IS_OUT_OF_BOUNDS = "Offset is out of bounds";
1 change: 1 addition & 0 deletions src/_util/primordials.mjs
Expand Up @@ -42,6 +42,7 @@ export const NativeNumber = Number;
export const {
isFinite: NumberIsFinite,
isNaN: NumberIsNaN,
MAX_SAFE_INTEGER: NumberMAX_SAFE_INTEGER,
} = NativeNumber;

// Symbol
Expand Down

0 comments on commit bf0bf5e

Please sign in to comment.