feat(clean): remove noRef helper because it is no longer needed for r…

…eact-redux

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Upgrade babel dependencies after greenkeeper based on https://github.com/transitive-bullshit/create-react-library/commit/df4d01feb28cba27ec5d0ffee6b107c1680be912#diff-272ba4df44ddd6215793bb638d2d239d
 ### Fixed
 ### Changed
+- Removed `noRef` workarounds for `react-redux`. `React-redux` no longer throws an error when passing an object and if we want to forward a reference to the inner component, we can use `forwardRef` option or wrap the connected component. See: https://github.com/reduxjs/react-redux/issues/914#issuecomment-377421145 and https://react-redux.js.org/api/connect#forwardref-boolean.
 
 ## [v2.1.1](https://github.com/pgarciacamou/react-context-consumer-hoc/releases/tag/v2.1.1) - 2018-10-15
 ### Added

README.md

@@ -226,22 +226,6 @@ export default withContext(
 )
 ```
 
-#### noRef
-
-`[withContext|withContextAsProps|UNSAFE_withContext].noRef`
-
-`noRef` is a simple wrapper built on top of all APIs which wraps the topmost consumer with a stateless function component (a function). to work around the `react-redux -> connect()` bug with React.forwardRef, see issue #6 for more information.
-
-```jsx
-export default connect(
-  function mapStateToProps(state, ownProps) { /* ... */ }
-)(
-  withContextAsProps.noRef(...)(MyComponent)
-  // or withContext.noRef([...], mapContextToProps)(MyComponent)
-  // or UNSAFE_withContext.noRef(...)(MyComponent)
-)
-```
-
 ## Author
 
 * Pablo Garcia [@pgarciacamou](https://twitter.com/pgarciacamou/)

example/src/index.js

@@ -2,6 +2,6 @@ import React from 'react'
 import ReactDOM from 'react-dom'
 
 import './index.css'
-import App from 'react-context-consumer-hoc/example/src/App-v2'
+import App from 'react-context-consumer-hoc/example/src/App-v3'
 
 ReactDOM.render(<App />, document.getElementById('root'))

src/UNSAFE_withContext.js

@@ -43,18 +43,4 @@ function UNSAFE_withContext(...ContextAPIs) {
   }
 }
 
-/**
- * Temporary workaround to fix react-redux issue with forwardRef.
- * This workaround will be removed on v3.
- *
- * Issue: https://github.com/pgarciacamou/react-context-consumer-hoc/issues/6
- */
-function noRef(...ContextAPIs) {
-  return ComposedComponent => {
-    const Component = UNSAFE_withContext(...ContextAPIs)(ComposedComponent)
-    return props => (<Component {...props} />)
-  }
-}
-
-UNSAFE_withContext.noRef = noRef
 export default UNSAFE_withContext

src/withContext.js

@@ -45,18 +45,4 @@ function withContext(ContextAPIs, mapContextToProps) {
   }
 }
 
-/**
- * Temporary workaround to fix react-redux issue with forwardRef.
- * This workaround will be removed on v3.
- *
- * Issue: https://github.com/pgarciacamou/react-context-consumer-hoc/issues/6
- */
-function noRef(ContextAPIs, mapContextToProps) {
-  return ComposedComponent => {
-    const Component = withContext(ContextAPIs, mapContextToProps)(ComposedComponent)
-    return props => (<Component {...props} />)
-  }
-}
-
-withContext.noRef = noRef
 export default withContext

src/withContextAsProps.js

@@ -6,18 +6,4 @@ function withContextAsProps(...ContextAPIs) {
   return withContext(ContextAPIs, mapContextToProps)
 }
 
-/**
- * Temporary workaround to fix react-redux issue with forwardRef.
- * This workaround will be removed on v3.
- *
- * Issue: https://github.com/pgarciacamou/react-context-consumer-hoc/issues/6
- */
-function noRef(...ContextAPIs) {
-  return ComposedComponent => {
-    const Component = withContext(ContextAPIs, mapContextToProps)(ComposedComponent)
-    return props => (<Component {...props} />)
-  }
-}
-
-withContextAsProps.noRef = noRef
 export default withContextAsProps