[feat] [broker] expose out bytes and message metrics per topic #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prometheus metrics which expose the per topic messages out and bytes out total on a per topic basis. Currently, only the subscription level stats are enabled.
Signed-off-by: Paul Gier paul.gier@datastax.com
Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
Each pull request should address only one issue, not mix up code from multiple issues.
Each commit in the pull request has a meaningful commit message
Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
Motivation
There are currently two metrics
pulsar_out_bytes_total
andpulsar_out_messages_total
. The metrics represent the pulsar stats on a per subscription basis. It would be convenient to be able to see the summary of these values per topic similar to the stats exposed by pulsar-admin.Modifications
Added the two metrics and updated the test to verify that the output is correct.
Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests). I made an enhancement to the existing Promtheus metrics test.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: