fix: PgObject isNull() was reporting the opposite fixes Issue #2411 (#…

…2414)
pgjdbc · Jan 19, 2022 · 4d494bf · 4d494bf
1 parent 9385985
commit 4d494bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pgjdbc/src/main/java/org/postgresql/util/PGobject.java b/pgjdbc/src/main/java/org/postgresql/util/PGobject.java
@@ -73,7 +73,7 @@ public final String getType() {
    * @return true if the current object wraps `null` value.
    */
   public boolean isNull() {
-    return getValue() != null;
+    return getValue() == null;
   }
 
   /**

diff --git a/pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGObjectSetTest.java b/pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGObjectSetTest.java
@@ -7,6 +7,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
 
 import org.postgresql.geometric.PGbox;
 import org.postgresql.geometric.PGcircle;
@@ -78,6 +79,7 @@ public void setNullAsPGobject() throws SQLException {
     PGobject object = new PGobject();
     object.setType(typeName);
     object.setValue(null);
+    assertTrue("IsNull should return true", object.isNull());
     testSet(object, expected, PGobject.class);
   }