test: fix metadata test to use explicit PK/FK names #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes testCrossReference() to validate the retrieved primary and foreign key columns against their expected values. Previously it would have accepted them in either order or the same value repeated twice for each. Also checks to ensure that the expected number of rows are actually returned. Previously it would have skipped all the checks if no rows were returned.
|
✅ Build pgjdbc 1.0.169 completed (commit 04a5ea632a by @sehrope) |
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
============================================
+ Coverage 68.74% 68.75% +0.01%
- Complexity 3902 3903 +1
============================================
Files 179 179
Lines 16414 16414
Branches 2672 2672
============================================
+ Hits 11284 11286 +2
+ Misses 3882 3881 -1
+ Partials 1248 1247 -1 |
bokken
approved these changes
Mar 16, 2019
vlsi
changed the title
|
🎉 |
vlsi
reviewed
Mar 16, 2019
| } | ||
| assertEquals(2, numRows); |
There was a problem hiding this comment.
Technically speaking, this should have been assertEquals("dbmd.getCrossReference should return 2 rows since primary key m_pkey was created as (m,n)", 2, numRows)
It does not hurt much, but it does bother when it fails like "expected: 2, got: 3".
The same for assertEquals above.
Something like assertEquals("FK column " + j, expectedFkColumnNames[j - 1], fkColumnName); would make failure messages much more convenient.
Thanks for the understanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis build against HEAD fails due to some changes in automated foreign key naming. Ex: #1435 (comment)_
This PR gives explicit names to the failing tests so that the results are consistent across versions.
Also, enhances the validation for that test to better validate the column order and row counts.