refactor: use oid=?::regtype when fetching pg_type by name instead of joining pg_namespace #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… joining pg_namespace This makes the query simpler, and it aligns the lookup semantics with the one of the database.
|
The change is not compatible with the previous behavior. However, I believe the incompatibility is subtle enough so we can ship it without a connection property. The database uses See b383f6d I think we should follow the DB behavior, and we should support only the types listed on the |
|
I agree that the change will be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the query simpler, and it aligns the lookup semantics with the one of the database.
There is a couple of places where
TypeInfoCachestill usestypname = ?, however, I am not sure regarding their semantics, so making a small change for now.