Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Netty to 4.1.77.Final #516

Merged
merged 1 commit into from May 25, 2022
Merged

Conversation

jczuchnowski
Copy link
Contributor

Resolves #514

Updates Netty to 4.1.77.Final along with reactor-bom to 2020.0.19. It seems like 2020.0.19 is newer than 2022.0.0-M2 and contains compatible Netty dependencies.

@mp911de
Copy link
Collaborator

mp911de commented May 24, 2022

The 2022.0.0 development line of Project Reactor ships a major version increment compared to the 2020.x development line.

@jczuchnowski
Copy link
Contributor Author

Oh, ok. So what is the course of action here? There's no new release for 2022.0.0 line.

@mp911de
Copy link
Collaborator

mp911de commented May 24, 2022

Did you test whether the newer netty version works against Reactor Netty 2022.0.0-M2? There should be no need to upgrade the Reactor version for now.

@jczuchnowski
Copy link
Contributor Author

Yes, Netty 4.1.77.Final works fine with Reactor 2022.0.0-M2. But this doesn't have any effect on the target project, as it still uses 4.1.76.Final from Reactor.

I was able to force my project to use Netty 4.1.77.Final by just explicitly adding the relevant dependency to build.sbt:

"io.netty" % "netty-transport-native-epoll" % "4.1.77.Final"

And this works regardless of this PR.

So I suppose we can treat it as a workaround for the time being.

@mp911de
Copy link
Collaborator

mp911de commented May 25, 2022

Care to update the PR to include just the netty version change and roll back the reactor change?

@jczuchnowski jczuchnowski changed the title Update Netty to 4.1.77.Final with a matching Reactor version Update Netty to 4.1.77.Final May 25, 2022
@jczuchnowski
Copy link
Contributor Author

Done.

@mp911de mp911de added the type: dependency-upgrade A dependency upgrade label May 25, 2022
@mp911de mp911de added this to the 0.8.13.RELEASE milestone May 25, 2022
@mp911de mp911de merged commit d008d64 into pgjdbc:main May 25, 2022
mp911de pushed a commit that referenced this pull request May 25, 2022
mp911de pushed a commit that referenced this pull request May 25, 2022
@mp911de
Copy link
Collaborator

mp911de commented May 25, 2022

Thank you for your contribution. That's merged and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to netty 4.1.77.Final to address epoll_wait() not implemented on Linux
2 participants