Fix: File upload property ‘stream’ is deprecated. Use ‘createReadStre…

…am()’ apollographql/apollo-server#2105
phamhongphuc · Dec 20, 2018 · 1ba3118 · 1ba3118
1 parent 35457e6
commit 1ba3118
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/server/database/model/Image.js b/server/database/model/Image.js
@@ -21,8 +21,8 @@ class Image extends Model {
 
         if (!isThrow(() => isPromiseValid(input.file))) {
             /** @type {import('../../graphql/interface/interface').FileUpload} */
-            const { stream, filename } = await input.file;
-            input.file = stream;
+            const { createReadStream, filename } = await input.file;
+            input.file = createReadStream();
             imageData.name = filename;
         }
         const imageFromImgur = await uploadImage(input.file);

diff --git a/server/graphql/interface/interface.ts b/server/graphql/interface/interface.ts
@@ -1,4 +1,4 @@
-import { Stream } from 'stream';
+import { ReadStream, PathLike } from 'fs';
 
 /**
  * @see {@link https://github.com/jaydenseric/graphql-upload/blob/master/src/GraphQLUpload.mjs}
@@ -19,5 +19,19 @@ export interface FileUpload {
     /**
      * Returns a Node.js readable stream of the file contents, for processing and storing the file. Multiple calls create independent streams. Throws if called after all resolvers have resolved, or after an error has interrupted the request.
      */
-    stream: Stream;
+    createReadStream: (
+        path: PathLike,
+        options?:
+            | string
+            | {
+                  flags?: string;
+                  encoding?: string;
+                  fd?: number;
+                  mode?: number;
+                  autoClose?: boolean;
+                  start?: number;
+                  end?: number;
+                  highWaterMark?: number;
+              },
+    ) => ReadStream;
 }