New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert alias => canonical relationship for dns_check_record and dns_get_mx #4821

Open

stevegrunwell wants to merge 1 commit into phan:v5 from stevegrunwell:fix/invert-deprecated-dns-functions

stevegrunwell commented Nov 30, 2023

According to the PHP manual, the following functions are aliases of their respective "canonical" name:

Canonical	Alias
checkdnsrr	dns_check_record()
getmxrr()	dns_get_mx()

However, the DeprecateAliasPlugin seems to have these inverted:

PhanDeprecatedFunctionInternal Call to deprecated function \checkdnsrr() (Deprecated because: DeprecateAliasPlugin marked this as an alias of dns_check_record())
PhanDeprecatedFunctionInternal Call to deprecated function \getmxrr() (Deprecated because: DeprecateAliasPlugin marked this as an alias of dns_get_mx())

This PR flips the relationships, which fixes #4798.


          Invert alias => canonical relationship for dns_check_record and dns_g…

9054d7c

…et_mx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment