Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to fix #16132 #16372

Open
wants to merge 1 commit into
base: Pharo11
Choose a base branch
from
Open

Conversation

doste
Copy link
Contributor

@doste doste commented Mar 29, 2024

Backport to have this fix: https://github.com/pharo-project/pharo/pull/16206/files on Pharo11

Copy link

welcome bot commented Mar 29, 2024

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@jecisc
Copy link
Member

jecisc commented Apr 2, 2024

I restarted the CI 

@jecisc
Copy link
Member

jecisc commented Apr 22, 2024

It has been two times that the build fail with:

etacelloNotification: ...RETRY->BaselineOfMicrodown

MetacelloNotification: ...RETRY->BaselineOfMicrodown

FileDoesNotExistException: '/tmp/github--pillarmarkupMicrodownintegration211177366495779428173017047329535926099.zip'

File>>openForWrite:

File>>openForRead

File>>readStream

FileHandle>>binaryReadStream

FileSystem>>binaryReadStreamOn:

FileReference>>binaryReadStream

ZipArchive>>readFrom:

MetacelloPharo30Platform(MetacelloPharoPlatform)>>downloadZipArchive:to:

MCGitHubRepository class(MCGitBasedNetworkRepository class)>>projectDirectoryFrom:version:

MCGitHubRepository(MCGitBasedNetworkRepository)>>calculateRepositoryDirectory

MCGitHubRepository(MCGitBasedNetworkRepository)>>resolveLocalRespository

MCGitHubRepository(MCGitBasedNetworkRepository)>>ensureLocalRepository

MCGitHubRepository(MCGitBasedNetworkRepository)>>localRepository

MCGitHubRepository(MCGitBasedNetworkRepository)>>goferReferences

[ aRepository goferReferences asSortedCollection asArray ] in MetacelloGofer(Gofer)>>basicReferencesIn: in Block: [ aRepository goferReferences asSortedCollecti[..]

FullBlockClosure(BlockClosure)>>on:do:

MetacelloGofer(Gofer)>>basicReferencesIn:

[ :cache | 

			^ cache at: aRepository put: (super basicReferencesIn: aRepository) ] in MetacelloGofer>>basicReferencesIn: in Block: [ :cache | ...

[:dict | | cache |

			cache := dict at: cacheName ifAbsent: [].

			cache ~~ nil

				ifTrue: [ | value hasEntry |

					hasEntry := true.

					value := cache at: key ifAbsent: [ hasEntry := false ].

@jecisc
Copy link
Member

jecisc commented May 21, 2024

Do we keep backporting to P11 when P12 is stable?

@Ducasse
Copy link
Member

Ducasse commented May 21, 2024

Nope but this is one is important so if it takes less than 5 min let us do it

@jecisc
Copy link
Member

jecisc commented May 21, 2024

The problem is that the P11 build seems to fail and I don't know why :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants